Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor nm-actions/install-whl #39

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Refactor nm-actions/install-whl #39

merged 2 commits into from
Nov 15, 2024

Conversation

dbarbuzzi
Copy link
Contributor

@dbarbuzzi dbarbuzzi commented Nov 15, 2024

This refactor reduces complexity (simpler conditional construct) and groups output for the install-whl action:

  • Inputs are mapped to environment variables, which significantly increases the readability when viewing the action invocation during a run. When you expand the action source, you can see all the variable names – when using inputs directly, they are replaced prior to this, meaning an empty input will simply have emptiness in the source code with no referential data.
  • Reduce the general complexity of the code in the action (e.g., eliminate branching conditionals).
  • Add output grouping — since this step is often used as part of another action, including output grouping is a considerable readability improvement for those runs, so this action’s output doesn’t forcibly increase noise during the run.

An example of these changes can be found in this run, under the “run e2e tests” step (see screenshot highlighting how the output is now grouped in that run): https://github.com/neuralmagic/llm-compressor-testing/actions/runs/11846143475/job/33013305664

image

This refactor reduces complexity (simpler conditional construct) and
groups output.
@dbarbuzzi dbarbuzzi added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit 8119f64 Nov 15, 2024
1 check passed
@dbarbuzzi dbarbuzzi deleted the refactor-install-whl branch November 15, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants